zhjwpku commented on code in PR #765:
URL: https://github.com/apache/iceberg-cpp/pull/765#discussion_r3446965893
##########
.github/workflows/aws_test.yml:
##########
@@ -113,11 +115,29 @@ jobs:
if: ${{ matrix.s3 == 'ON' }}
shell: bash
run: bash ci/scripts/start_minio.sh
+ - name: Restore sccache cache
+ uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae #
v5.0.5
Review Comment:
It looks like the Windows workflow was using
`mozilla-actions/sccache-action` together with `SCCACHE_GHA_ENABLED`, while
this PR changes it to use explicit `actions/cache` restore/save steps plus
`mozilla-actions/sccache-action`.
I'm not sure which approach is better, but in case you missed it,
`mozilla-actions/sccache-action` README documents the `SCCACHE_GHA_ENABLED`
setup here:
https://github.com/mozilla-actions/sccache-action#cc-code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
