laskoviymishka opened a new issue, #1232: URL: https://github.com/apache/iceberg-go/issues/1232
Follow-up to #1138. `icebergCRSToGeoArrowMetadata` panics on an unsupported (projjson) CRS, while the symmetric read function `geoArrowCRSToIcebergCRS` returns a clean error for the same case. It only works today because `iceberg.Visit`'s deferred recover catches the panic — call the function outside a visitor and it blows up. Proposal: give `icebergCRSToGeoArrowMetadata` a `(geoarrow.Metadata, error)` signature, and have `VisitGeometry`/`VisitGeography` panic-with-error to thread it through the visitor recover (the convention the other visitor methods already use). That removes the read/write asymmetry and makes the function safe to call on its own. This is the only one of the #1138 follow-ups that touches a signature, so it's cleaner as its own PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
