evindj commented on code in PR #701: URL: https://github.com/apache/iceberg-cpp/pull/701#discussion_r3440161939
########## src/iceberg/catalog/rest/rest_catalog.cc: ########## @@ -185,7 +188,7 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make( } RestCatalog::RestCatalog(RestCatalogProperties config, std::shared_ptr<FileIO> file_io, - std::unique_ptr<HttpClient> client, + std::shared_ptr<HttpClient> client, Review Comment: because MakeTableReporter() hands the same client to a per-table RestMetricsReporter that must keep posting metrics independently of the catalog's lifetime. alternatively we can make the table reporter own an httpClient but I feel like the burden of initialization could be high -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
