adutra commented on PR #15989: URL: https://github.com/apache/iceberg/pull/15989#issuecomment-4741645821
> @adutra couldn't we fix this by keeping `decodeString` everywhere? It's been a while since I looked into this, but I believe `URLDecoder.decode` is already lenient and can handle `+` and `%20` properly. Yes, keeping `decodeString` for decoding path segments encoded with `encodePathSegment` would work. This is the "newer client with older server" use case and the reason why upgrading clients is a safe move. This is also why `decodePathSegment` (and `decodeNamespaceAsPathSegment`) are currently "unplugged". Are you implying that you would rather have `decodePathSegment` (and `decodeNamespaceAsPathSegment`) completely removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
