fallintoplace opened a new pull request, #755: URL: https://github.com/apache/iceberg-cpp/pull/755
## Summary - compute integer truncate remainders with a wider signed type to avoid signed overflow - preserve modulo behavior for the min-value boundary where the mathematical result falls below the source type - add regression coverage for large positive widths and int/long minimum values ## Validation - `cmake -S . -B build-truncate -G Ninja -DICEBERG_BUILD_BUNDLE=OFF -DICEBERG_BUILD_REST=OFF -DICEBERG_BUILD_SHARED=OFF -DICEBERG_ENABLE_UBSAN=ON` - `UBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1 ctest --test-dir build-truncate -R util_test --output-on-failure` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
