aokolnychyi commented on code in PR #14984:
URL: https://github.com/apache/iceberg/pull/14984#discussion_r3432278645
##########
spark/v4.2/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala:
##########
@@ -28,39 +28,27 @@ import org.apache.spark.sql.catalyst.plans.logical.View
import org.apache.spark.sql.catalyst.plans.logical.views.CreateIcebergView
import org.apache.spark.sql.catalyst.plans.logical.views.ResolvedV2View
import org.apache.spark.sql.connector.catalog.ViewCatalog
-import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.util.SchemaUtils
object CheckViews extends (LogicalPlan => Unit) {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
override def apply(plan: LogicalPlan): Unit = {
plan foreach {
- case CreateIcebergView(
- resolvedIdent @ ResolvedIdentifier(_: ViewCatalog, _),
- _,
- query,
- columnAliases,
- _,
- _,
- _,
- _,
- _,
- replace,
- _,
- _) =>
- verifyColumnCount(resolvedIdent, columnAliases, query)
- SchemaUtils.checkColumnNameDuplication(
- query.schema.fieldNames.toIndexedSeq,
- SQLConf.get.resolver)
- if (replace) {
- val viewIdent: Seq[String] =
- resolvedIdent.catalog.name() +:
resolvedIdent.identifier.asMultipartIdentifier
- checkCyclicViewReference(viewIdent, query, Seq(viewIdent))
+ case c: CreateIcebergView =>
Review Comment:
Can this move to Spark now? Is it fully implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
