zhjwpku commented on code in PR #3517:
URL: https://github.com/apache/iceberg-python/pull/3517#discussion_r3424728979
##########
pyiceberg/transforms.py:
##########
@@ -717,7 +719,7 @@ def transform(self, source: IcebergType) -> Callable[[S |
None], S | None]:
return lambda v: v
def can_transform(self, source: IcebergType) -> bool:
- return source.is_primitive
+ return source.is_primitive and not isinstance(source, (GeographyType,
GeometryType))
Review Comment:
Yeah, I agree we should follow the spec before a decision is made to change
it. However, after searching the codebase, it seems that `VariantType` is not
currently supported in Iceberg Python, and supporting `VariantType` feels like
a much broader effort that should probably be addressed in a separate PR, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
