rambleraptor opened a new pull request, #3519:
URL: https://github.com/apache/iceberg-python/pull/3519
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
We've diverged from the Java implementation for TruncateTransform.project
In
[Java](https://github.com/apache/iceberg/blob/34cd01ba2e057866cdb13db8f9919bc98e11e638/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L339-L346),
we return `null` when length > width. This means that the predicated can't be
projected.
## Are these changes tested?
We had one test that was (incorrectly) passing. I've changed up the test to
test the three use-cases: `length < width`, `length == width`, `length >
width`. This better matches the test suite from Java.
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
