dannycjones commented on PR #2657: URL: https://github.com/apache/iceberg-rust/pull/2657#issuecomment-4721736215
> I'm hesitating adding this script, upgrading rust toolchain and msrv is just one line change and a simple lookup, there is no need to automate this with maintaining burden. I share the hesitation. The script ended up being longer than expecting (and easy for GenAI to churn out) for minimal gain. It only skips the manual process of browsing the release page and picking out a good version matching the criteria. The flip side (why I tried writing it) was to be able to add a simple script to run in the release guide and/or whenever someone wants to update MSRV. It'll cover not just the `Cargo.toml` but also the Rust toolchain used by clippy, etc. I'm happy to close it, unless someone wants to include it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
