wgtmac commented on code in PR #699:
URL: https://github.com/apache/iceberg-cpp/pull/699#discussion_r3418868751
##########
src/iceberg/table.h:
##########
@@ -176,6 +176,9 @@ class ICEBERG_EXPORT Table : public
std::enable_shared_from_this<Table> {
/// \brief Create a new FastAppend to append data files and commit the
changes.
virtual Result<std::shared_ptr<FastAppend>> NewFastAppend();
+ /// \brief Create a new MergeAppend to append data files and merge manifests.
+ virtual Result<std::shared_ptr<MergeAppend>> NewMergeAppend();
Review Comment:
StaticTable also needs to override this and return NotSupported. Otherwise a
read-only StaticTable inherits Table::NewMergeAppend(), creates a mutating
snapshot update, and later hits the null catalog path during commit. The
existing static-table test should cover this alongside NewFastAppend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
