plusplusjiajia commented on code in PR #2651:
URL: https://github.com/apache/iceberg-rust/pull/2651#discussion_r3415284041
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1076,6 +1074,23 @@ impl Catalog for RestCatalog {
}
}
+/// FileIO props: server `config`, then vended `storage_credentials` (longest
prefix wins), then user props.
+fn table_file_io_config(
Review Comment:
@xanderbailey Thanks, agreed. Each vended credential now maps to its own
storage instead of merging all into one props map. FileIO routes each path to
the longest-matching prefix(with_prefixed_props/get_storage); removed
table_file_io_config.
On silent failures: this matches Java's S3FileIO.clientForStoragePath — a
path matching no credential prefix falls back to the default storage from base
properties (longest-prefix-match), so a real access problem surfaces as a
normal I/O error, not a silent no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
