dttung2905 opened a new pull request, #1201: URL: https://github.com/apache/iceberg-go/pull/1201
During commit, summary() loads the parent snapshot to inherit its summary properties before calling updateSnapshotSummaries: https://github.com/apache/iceberg-go/blob/1e4916f7a79462d193ed65d672545ff71fa6f556/table/snapshot_producers.go#L810-L827 If lookup failed, ``previousSnapshot` stayed nil, `previousSummary` was never set, and updateSnapshotSummaries fell back to zero baselines. That produced incorrect incremental snapshot summary properties (total-data-files, total-records, etc.) with no error surfaced to the caller. The same lookup in `computeOwnManifests` already propagates the error and is covered by `TestComputeOwnManifests_SnapshotByIDError`; the summary path did not. https://github.com/apache/iceberg-go/blob/1e4916f7a79462d193ed65d672545ff71fa6f556/table/snapshot_producers.go#L833-L842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
