fallintoplace opened a new pull request, #3492: URL: https://github.com/apache/iceberg-python/pull/3492
# Rationale for this change `FsspecFileIO` checked `s3.force-virtual-addressing` with raw property truthiness. That meant `"false"` still enabled virtual-host addressing because it is a non-empty string. This changes the fsspec S3 setup to use the existing boolean property parser, matching the rest of the codebase and preserving the default behavior when the property is absent. ## Are these changes tested? - `PYTHONPATH=. uv run --extra s3fs pytest tests/io/test_fsspec.py::test_fsspec_s3_session_properties_force_virtual_addressing` - `PYTHONPATH=. uv run --extra s3fs pytest tests/io/test_fsspec.py -k "s3_session_properties"` - `uv run prek run ruff --files pyiceberg/io/fsspec.py tests/io/test_fsspec.py` - `uv run prek run ruff-format --files pyiceberg/io/fsspec.py tests/io/test_fsspec.py` ## Are there any user-facing changes? Yes. Setting `s3.force-virtual-addressing=false` for fsspec S3 FileIO now leaves the default addressing behavior unchanged instead of forcing virtual addressing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
