nastra commented on code in PR #16793:
URL: https://github.com/apache/iceberg/pull/16793#discussion_r3407580243
##########
common/src/main/java/org/apache/iceberg/common/DynConstructors.java:
##########
@@ -222,7 +222,7 @@ public <C> Ctor<C> build() {
private Class<?> classForName(String className) throws
ClassNotFoundException {
try {
return Class.forName(className, true, loader);
- } catch (ClassNotFoundException e) {
+ } catch (ClassNotFoundException | NoClassDefFoundError e) {
Review Comment:
@wombatu-kun I talked offline with @rdblue about this. All of the `Dyn*`
classes are affected by the same issue. The only difference is that for the
`Dyn*` classes we want to propagate the `ExceptionInInitializerError` to the
caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
