kevinjqliu opened a new issue, #1199:
URL: https://github.com/apache/iceberg-go/issues/1199

   LGTM 
   
   lets merge this and add the tests as a follow up. 
   - test day transform writes as avro date
   - test can read partition value encoded as either avro int or avro date 
   
   we also dont necessarily need `TestNonDayInt32PartitionAvroIntEncoding`, 
bucket transform encoding is likely tested elsewhere
   
   _Originally posted by @kevinjqliu in 
https://github.com/apache/iceberg-go/pull/915#pullrequestreview-4472530481_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to