smaheshwar-pltr commented on code in PR #16796:
URL: https://github.com/apache/iceberg/pull/16796#discussion_r3406544248


##########
docs/docs/configuration.md:
##########
@@ -80,7 +80,7 @@ Iceberg tables support table properties to configure table 
behavior, like the de
 | write.wap.enabled                                   | false                  
     | Enables write-audit-publish writes                                       
                                                                                
                                                                                
          |
 | write.summary.partition-limit                       | 0                      
     | Includes partition-level summary stats in snapshot summaries if the 
changed partition count is less than this limit                                 
                                                                                
               |
 | write.metadata.delete-after-commit.enabled          | false                  
     | Controls whether to delete the oldest **tracked** version metadata files 
after each table commit. See the [Remove old metadata 
files](maintenance.md#remove-old-metadata-files) section for additional details 
                                    |
-| write.metadata.previous-versions-max                | 100                    
     | The max number of previous version metadata files to track               
                                                                                
                                                                                
          |
+| write.metadata.previous-versions-max                | 100                    
     | The max number of previous version metadata files to track. A value of 
`0` keeps no previous metadata files (an empty `metadata-log`)                  
                                                                                
             |

Review Comment:
   Pointing out that I'm not including a spec change in this PR because I kind 
of think 
   
   > A list (optional) of timestamp and metadata file location pairs that 
encodes changes to the previous metadata files for the table. Each time a new 
metadata file is created, a new entry of the previous metadata file location 
should be added to the list. Tables can be configured to remove oldest metadata 
log entries and keep a fixed-size log of the most recent entries after a commit.
   
   from https://iceberg.apache.org/spec/#table-metadata is worded consistently 
with a value of 0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to