fallintoplace opened a new pull request, #1197: URL: https://github.com/apache/iceberg-go/pull/1197
Summary - add `timestamp_ns` and `timestamptz_ns` support to `BucketTransform.Apply` and `BucketTransform.Transformer` - keep bucket hashing on the physical integer timestamp value - add regression coverage for Apply, Transformer, and Project paths, including a pre-epoch ns value Why `BucketTransform.CanTransform` already accepted nanosecond timestamp types, but `Apply` returned an invalid optional for `TimestampNsLiteral` and `Transformer` could return a closure with a nil hash function. That made `bucket(timestamp_ns)` unsafe for partition value generation and predicate projection. Testing - `go test . -run "TestBucketTransformTimestampNanoseconds|TestCanTransform|TestManifestPartitionVals" -count=1` - `go test ./... -count=1` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
