zeroshade commented on PR #1193: URL: https://github.com/apache/iceberg-go/pull/1193#issuecomment-4695089799
> One small thing: literalLen handles BinaryLiteral/FixedLiteral and the new block sits above the type switch, so binary truncate fields go through the same path — but there's no binary regression test (only TestStringTruncateProjection). Worth adding a binary NotStartsWith case so that path is locked in too? I agree with @tanmayrauth here, let's add a test case to cover the binary/FixedLiteral case. Also, @kevinjqliu @Fokko I think that pyiceberg might share this same bug, might be worth investigating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
