fallintoplace opened a new pull request, #2630:
URL: https://github.com/apache/iceberg-rust/pull/2630
## Summary
- Reuse an existing equality-delete load notifier instead of overwriting it
with a new one.
- Keep the loader path scoped to the existing start-load state machine.
- Add a regression test that polls a waiter before the load is inserted,
then verifies it is notified when the predicate is loaded.
## Root cause
marked a delete file as with one , but replaced the map entry with a
different . Any reader that observed the first notifier could wait forever
because only the second notifier was signaled.
## Tests
-
-
running 1 test
test
arrow::delete_filter::tests::test_equality_delete_waiter_is_notified_after_load_started
... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1312 filtered
out; finished in 0.00s
-
running 3 tests
test
arrow::delete_filter::tests::test_equality_delete_waiter_is_notified_after_load_started
... ok
test
arrow::delete_filter::tests::test_build_equality_delete_predicate_case_sensitive
... ok
test arrow::delete_filter::tests::test_delete_file_filter_load_deletes ... ok
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 1310 filtered
out; finished in 0.00s
-
running 6 tests
test
arrow::caching_delete_file_loader::tests::test_partial_schema_equality_deletes_evolve_succeeds
... ok
test
arrow::caching_delete_file_loader::tests::test_delete_file_loader_parse_equality_deletes
... ok
test
arrow::caching_delete_file_loader::tests::test_caching_delete_file_loader_load_deletes
... ok
test
arrow::caching_delete_file_loader::tests::test_caching_delete_file_loader_caches_results
... ok
test
arrow::caching_delete_file_loader::tests::test_load_deletes_with_mixed_types
... ok
test
arrow::caching_delete_file_loader::tests::test_large_equality_delete_batch_stack_overflow
... ok
test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 1307 filtered
out; finished in 0.04s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
