strophy commented on PR #1194: URL: https://github.com/apache/iceberg-go/pull/1194#issuecomment-4692737017
Hi @zeroshade thanks for the lightning-quick review! A quick disclaimer, I'm an Alpine package maintainer, not a specialist in s390x or Golang, so I'm leaning heavily on AI here and careful review (or a better solution) is needed. Apologies in advance if this is against your contibutor guidelines, this is a [genuine bug I'm hitting](https://gitlab.alpinelinux.org/strophy/aports/-/jobs/2387614) and not a drive-by slop PR. :sweat_smile: According to Claude, there is no way to keep the zero-value initialization because: - The failure site is the generic instantiation path, not comparator logic: it blows up at `getComparator`/`newStatAgg` specialization time, before any bool comparison executes. - The problematic pattern is the zero-value generic conversion path in `iceberg-go/literals.go` and the former generic helper call sites in `iceberg-go/manifest.go` and `iceberg-go/table/internal/utils.go`. - Changing the body of `BoolLiteral.Comparator` in `iceberg-go/literals.go` does not remove the monomorphization/type-assertion path that triggers the s390x alignment issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
