wombatu-kun commented on code in PR #16770:
URL: https://github.com/apache/iceberg/pull/16770#discussion_r3400254188
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -426,8 +426,10 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Exception {
SCHEMA,
SPEC,
ImmutableMap.of(
+ // Use a high retry count so no committer exhausts its retries
under the forced
+ // lock-step contention below (matches
Test{Jdbc,Hive}TableConcurrency).
COMMIT_NUM_RETRIES,
- String.valueOf(threadsCount),
+ "20",
Review Comment:
Because two sibling optimistic-commit concurrency tests
TestJdbcTableConcurrency and TestHiveTableConcurrency both use 20 retries, and
it looks like it's enough avoid flakiness this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
