CTTY commented on code in PR #2623:
URL: https://github.com/apache/iceberg-rust/pull/2623#discussion_r3399904659
##########
crates/catalog/s3tables/src/utils.rs:
##########
@@ -39,10 +39,6 @@ pub(crate) async fn create_sdk_config(
) -> SdkConfig {
let mut config = aws_config::defaults(BehaviorVersion::latest());
- if properties.is_empty() {
- return config.load().await;
- }
-
Review Comment:
Should we just move this block to after the endpoint_url check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
