CTTY commented on code in PR #2612:
URL: https://github.com/apache/iceberg-rust/pull/2612#discussion_r3399272933
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -133,6 +133,12 @@ impl FileScanTaskReader {
.next()
.is_some_and(|f|
f.metadata().get(PARQUET_FIELD_ID_META_KEY).is_none());
+ // Position-based fallback applies only when the file has no embedded
field IDs
+ // AND no name mapping is available. With a name mapping, field IDs
are assigned
+ // to the Arrow schema below, and projection/predicate planning must
use them
+ // (see #2403).
+ let use_position_fallback = missing_field_ids &&
task.name_mapping.is_none();
Review Comment:
nit: I think the logic and comment here is slightly duplicate to "Branch 3"
right after it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
