rdblue commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3399255718


##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -158,6 +141,20 @@ void testDoNotInheritSequenceNumberForExistingEntries() {
     assertThat(tracking.fileSequenceNumber()).isEqualTo(6L);
   }
 
+  @Test
+  void testDoNotInheritSequenceNumberForModifiedEntries() {
+    TrackingStruct tracking = new TrackingStruct(Tracking.schema());
+    tracking.set(STATUS_ORDINAL, EntryStatus.MODIFIED.id());
+    tracking.set(DATA_SEQUENCE_NUMBER_ORDINAL, 5L);
+    tracking.set(FILE_SEQUENCE_NUMBER_ORDINAL, 6L);

Review Comment:
   Because these are set, this wouldn't be inherited even if `MODIFIED` 
inherited the values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to