rdblue commented on code in PR #16727:
URL: https://github.com/apache/iceberg/pull/16727#discussion_r3399170051
##########
format/udf-spec.md:
##########
@@ -117,8 +117,14 @@ following fields required. Any other fields must be
ignored.
e.g., `{ "type": "struct", "fields": [ { "name": "id", "type": "int" }, {
"name": "name", "type": "string" } ] }`
#### Definition ID
-The `definition-id` is a canonical string derived from the parameter types,
formatted as a comma-separated list with no
-spaces. Each type uses the following string representation:
+The `definition-id` is a string that uniquely identifies a definition within
the UDF metadata. It may be a user-specified
Review Comment:
I think it would be fine to add an optional `specific-name` but I don't see
a reason to change how `definition-id` works. That is derived from the
parameters and I don't see a reason to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
