pvary commented on code in PR #16769:
URL: https://github.com/apache/iceberg/pull/16769#discussion_r3395699207


##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -344,19 +340,23 @@ static TrackedFileStruct createFullTrackedFile() {
             .build();
 
     TrackedFileStruct file =
-        new TrackedFileStruct(
-            tracking,
-            FileContent.DATA,
-            "s3://bucket/data/file.parquet",
-            FileFormat.PARQUET,
-            newPartition(7, "music"),
-            100L,
-            1024L);
-    file.set(6, 0);
-    file.set(9, 1);
-    file.set(10, dv);
-    file.set(12, ByteBuffer.wrap(new byte[] {1, 2, 3}));
-    file.set(13, ImmutableList.of(50L));
+        (TrackedFileStruct)

Review Comment:
   Are we sure that we want to test the struct through the builder?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to