gerinsp commented on code in PR #1179:
URL: https://github.com/apache/iceberg-go/pull/1179#discussion_r3392926133
##########
manifest.go:
##########
@@ -1848,6 +1848,10 @@ func (d *dataFile) initColumnStatsData() {
}
func (d *dataFile) convertAvroValueToIcebergType(v any, fieldID int) any {
+ if v == nil {
Review Comment:
Done. I added an explicit nil branch in `eqDeletePartitionsToFilter` so
null identity partition values emit an IS NULL predicate instead of flowing
into `anyToLiteral`.
I also added a regression test that drives the equality-delete conflick
validation patch with a nullidentity partition value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
