j1wonpark commented on code in PR #16716:
URL: https://github.com/apache/iceberg/pull/16716#discussion_r3392270856
##########
spark/v4.1/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -121,32 +124,46 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface)
/**
* Parse a string to a LogicalPlan, binding the given parameters.
- *
- * Iceberg DDL grammars do not accept parameter markers (`?` / `:name`), so
the
- * parameterContext is only forwarded to the delegate on the non-Iceberg
path.
*/
override def parsePlanWithParameters(
sqlText: String,
parameterContext: ParameterContext): LogicalPlan =
Review Comment:
Done — wrapped the context with `Option(...)` so a null context is treated
as no parameters, and added a null-context test in `TestExtendedParser`. Thanks
for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
