gaborkaszab commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3389148405
##########
core/src/main/java/org/apache/iceberg/Tracking.java:
##########
@@ -83,10 +83,12 @@ static Types.StructType schema() {
/** Returns whether this entry is live. */
default boolean isLive() {
- return status() == EntryStatus.ADDED || status() == EntryStatus.EXISTING;
+ return status() == EntryStatus.ADDED
+ || status() == EntryStatus.EXISTING
+ || status() == EntryStatus.MODIFIED;
Review Comment:
Maybe for convenience we can still have `Tracked.isLive()` that simply
delegates to `EntryStatus` as Ryan suggested:
```
default boolean isLive() {
return status().isLive();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
