rahulsmahadev commented on PR #3418:
URL: https://github.com/apache/iceberg-python/pull/3418#issuecomment-4665220301

   Linters are now passing — `afb1f51` fixed the last mypy holdouts: I'd used 
`MutableMapping` for the `proxies` parameter on the overridden 
`HTTPAdapter.send`, but the parent (per `types-requests`) declares it as 
`Mapping`, and overriding with a more specific type is an invalid variance 
under strict mypy. Switched to `Mapping`. All 17 checks green now. PTAL!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to