parthchandra commented on issue #2607: URL: https://github.com/apache/iceberg-rust/issues/2607#issuecomment-4662459770
> Is this semantically different than the `row_number` virtual column that arrow-rs already supports that I recently threaded through DataFusion? [apache/datafusion#22026](https://github.com/apache/datafusion/pull/22026) Great catch! Turns out they are the same. In iceberg-java `PositionVectorReader` (VectorizedArrowReader.java:673): - Gets rowStart from PageReadStore.getRowIndexOffset() per row group - position = rowGroupStartOffset + indexInBatch Which is also what arrow-rs does. Updated the description. Thank you @mbutrovich ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
