rdblue commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3375988595
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +145,17 @@ Tracking build() {
replacedPositions);
}
+ /**
+ * Promotes an EXISTING entry to MODIFIED on mutation. Fresh-add builders
(status = ADDED) are
+ * preserved — covers the same-commit append + DV attach case without a
special branch.
+ */
+ private void promoteToModified() {
+ if (status == EntryStatus.EXISTING) {
+ this.status = EntryStatus.MODIFIED;
+ this.snapshotId = newSnapshotId;
Review Comment:
Why is this setting the snapshot ID of a MODIFIED entry? The modification
should set a specific snapshot ID, like the `dvSnapshotId`. We don't set the
entry's snapshot ID when it is changed because we still want to know when the
base file itself was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
