dttung2905 commented on code in PR #41: URL: https://github.com/apache/terraform-provider-iceberg/pull/41#discussion_r3375806311
########## Makefile: ########## @@ -15,6 +15,10 @@ .PHONY: test-integration test-integration-setup test-integration-exec test-integration-cleanup +test-integration: ## Start Docker services, run integration tests, then tear down + @$(MAKE) test-integration-setup Review Comment: Hi @rambleraptor my idea was that the recursive make calls reuse the existing sub-targets and guarantee cleanup runs even when tests fail (the `EXIT=$$?` pattern). A plain dependency list like `test-integration: setup exec cleanup` would skip cleanup on test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
