szehon-ho commented on PR #15180: URL: https://github.com/apache/iceberg/pull/15180#issuecomment-4635602962
Hi @huaxingao i had some questions on this . Sorry I guess I missed the earlier discussion on Function, so it may be a bit late. I had a chance to chat a bit with @srielau offline to get his SQL expertise. First, the versioning and overload looks great. But SQL standard has a concept of 'routine name' for the functions with same name, and 'specific name' for different function overloads. It makes sense to add it to the model as well. Was that ever discussed? I know here we do have the defintiion-id. Otherwise, it looks great. I think the name 'routine' rather than 'function' is more conforming to the SQL standard, but at this point it might be late to change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
