gaborkaszab commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3365299013
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +149,29 @@ Tracking build() {
replacedPositions);
}
+ /** Derives the output status from the source, the snapshot, and any
mutations. */
+ private EntryStatus deriveStatus() {
+ if (source == null) {
+ return EntryStatus.ADDED;
+ }
+
+ boolean sameSnapshot = source.snapshotId() != null && source.snapshotId()
== newSnapshotId;
Review Comment:
Do you mean
[this](https://github.com/apache/iceberg/pull/16408#discussion_r3324173342)
conversation? If yes, it was about whether to return `Tracking` or
`TrackingBuilder` from `added(long)`. The argument was to return the latter,
because we might want to add some DVs on top using the **same** builder.
However, here it seems slightly different: We first build a `Tracking`
object with ADDED status, then use it as a source to add DVs on top using
**another** builder. For this, we could use `Tracking` as a return value from
`added(long)`
(I'll think this through tomorrow again)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
