rambleraptor commented on code in PR #3458:
URL: https://github.com/apache/iceberg-python/pull/3458#discussion_r3364001919
##########
tests/catalog/test_rest.py:
##########
@@ -1746,10 +1746,7 @@ def test_create_view_200(rest_mock: Mocker,
table_schema_simple: Schema, example
identifier=("fokko", "fokko2"),
schema=table_schema_simple,
view_version=ViewVersion(
- version_id=1,
- timestamp_ms=12345,
schema_id=1,
- summary={"engine-name": "spark", "engineVersion": "3.3"},
Review Comment:
We should keep this summary here, since it's not the default.
##########
tests/catalog/test_rest.py:
##########
@@ -1791,10 +1788,7 @@ def test_create_view_409(
identifier=("fokko", "fokko2"),
schema=table_schema_simple,
view_version=ViewVersion(
- version_id=1,
- timestamp_ms=12345,
schema_id=1,
- summary={"engine-name": "spark", "engineVersion": "3.3"},
Review Comment:
Keep this summary since not default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
