anoopj commented on code in PR #16689: URL: https://github.com/apache/iceberg/pull/16689#discussion_r3363311261
########## core/src/test/java/org/apache/iceberg/TestTrackingStruct.java: ########## @@ -493,7 +588,7 @@ void testAddedWithDvSnapshotIdJavaSerializationRoundTrip() } @Test - void testExistingWithManifestDVPositionsJavaSerializationRoundTrip() + void testModifiedWithManifestDVPositionsJavaSerializationRoundTrip() Review Comment: We need two tests: one for data files and one for manifests (to test out MDV etc). The current names were not great. I renamed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
