huaxingao commented on code in PR #16327:
URL: https://github.com/apache/iceberg/pull/16327#discussion_r3360274645


##########
docs/docs/configuration.md:
##########
@@ -44,6 +44,7 @@ Iceberg tables support table properties to configure table 
behavior, like the de
 | write.format.default                                | parquet                
     | Default file format for the table; parquet, avro, or orc                 
                                                                                
                                                                                
          |
 | write.delete.format.default                         | data file format       
     | Default delete file format for the table; parquet, avro, or orc          
                                                                                
                                                                                
          |
 | write.parquet.row-group-size-bytes                  | 134217728 (128 MB)     
     | Parquet row group size                                                   
                                                                                
                                                                                
          |
+| write.parquet.row-group-size-check-uncompressed     | false                  
     | Track raw data size before encoding and compression to enforce the row 
group size target                                                               
                                                                                
             |

Review Comment:
   Seems to me `getBufferedSize()` returns post-encoding, pre-compression 
bytes. Could you please verify this is before encoding or after encoding?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to