gaborkaszab commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3347558102


##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -98,9 +101,9 @@ void testFieldAccess() {
   void testReaderSideFields() {
     TrackedFileStruct file = new TrackedFileStruct();
 
-    TrackingStruct tracking = 
TrackingStruct.builder().status(EntryStatus.ADDED).build();
+    TrackingStruct tracking = new TrackingStruct();

Review Comment:
   nit: can't this creation go through the builder?
   Not sure if the intent here is to test the "Constructor for Java 
serialization". If yes, shouldn't that coverage be in a test suite for the 
serialization



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to