paveon commented on code in PR #1133:
URL: https://github.com/apache/iceberg-go/pull/1133#discussion_r3328876684
##########
table/orphan_cleanup.go:
##########
@@ -164,7 +166,7 @@ type OrphanCleanupResult struct {
TotalSizeBytes int64
}
-func (t Table) DeleteOrphanFiles(ctx context.Context, opts
...OrphanCleanupOption) (OrphanCleanupResult, error) {
+func (t *Table) DeleteOrphanFiles(ctx context.Context, opts
...OrphanCleanupOption) (OrphanCleanupResult, error) {
Review Comment:
It got flagged by my IDE because some methods already use pointer receivers
so I changed it but forgot to change it back after I noticed that most of the
public API uses value receivers 😅 `Struct Table has methods on both value and
pointer receivers. Such usage is not recommended by the Go Documentation.`
I reverted the change 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
