zhjwpku commented on issue #690: URL: https://github.com/apache/iceberg-cpp/issues/690#issuecomment-4581927886
It seems that all `RETURN_IF_NOT_REFERENCE` usages share the same pattern, so +1 for this improvement. For benchmarking, we discussed [0] this briefly when choosing the unit test framework. Another option besides Google Test was Catch2 [1], which has microbenchmark and BDD features. We didn't choose it back then because most people involved were more familiar with Google Test. Maybe it's time to spend some effort evaluating the benchmarking infrastructure and making a choice. [0] https://github.com/apache/iceberg-cpp/issues/12 [1] https://github.com/catchorg/Catch2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
