anoopj commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3327502308
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
@@ -51,7 +51,7 @@ private DeletionVectorStruct(DeletionVectorStruct toCopy) {
}
private DeletionVectorStruct(String location, long offset, long sizeInBytes,
long cardinality) {
Review Comment:
This is a great question. Switching the required fields to objects incur the
boxing penalty during reads, which could be a significant overhead. This is
also the convention we follow in existing code (`BaseFIle`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
