mbutrovich commented on code in PR #2188:
URL: https://github.com/apache/iceberg-rust/pull/2188#discussion_r3326698424
##########
crates/iceberg/src/transaction/update_schema.rs:
##########
@@ -180,7 +180,7 @@ fn assign_fresh_ids(field: &NestedField, next_id: &mut i32)
-> NestedFieldRef {
/// Recursively assign fresh field IDs to all nested fields within a `Type`.
fn assign_fresh_ids_to_type(field_type: &Type, next_id: &mut i32) -> Type {
match field_type {
- Type::Primitive(_) => field_type.clone(),
+ Type::Primitive(_) | Type::Variant(_) => field_type.clone(),
Review Comment:
Style mismatch with `id_reassigner.rs:105`: that file does `Type::Variant(v)
=> Ok(Type::Variant(v))`, this one folds Variant into the primitive arm with
`field_type.clone()`. Both work since `VariantType` is `Copy`. Picking one
would be slightly easier on future readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
