abnobdoss commented on code in PR #3387:
URL: https://github.com/apache/iceberg-python/pull/3387#discussion_r3321956520
##########
tests/table/test_upsert.py:
##########
@@ -888,3 +892,176 @@ def test_upsert_snapshot_properties(catalog: Catalog) ->
None:
for snapshot in snapshots[initial_snapshot_count:]:
assert snapshot.summary is not None
assert snapshot.summary.additional_properties.get("test_prop") ==
"test_value"
+
+
+class TestUpsertScanProjection:
Review Comment:
This feels slightly excessive to test the destination scan's fields are
filtered - would one or two test functions suffice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
