nnguyen168 commented on issue #16493: URL: https://github.com/apache/iceberg/issues/16493#issuecomment-4563398490
Thanks @rdblue for the clarification. I understand now that the primary concern is `listedFileDS()` and the `FileSystemWalker` methods making storage requests without the trailing `/`. One follow-up: I noticed `filteredCompareToFileList()` line 228 also uses a raw `startsWith(location)` without path separator validation. While this doesn't make storage calls, it could still match sibling paths if the caller's file list contains them (e.g., `table-backup/` matching `table`). Should this also be fixed as part of this issue, or is that considered acceptable since the caller provided the file list? I'll focus on `FileSystemWalker.listDirRecursivelyWithFileIO` and `listDirRecursivelyWithHadoop` for the main fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
