wgtmac commented on code in PR #682:
URL: https://github.com/apache/iceberg-cpp/pull/682#discussion_r3316745788
##########
src/iceberg/manifest/manifest_filter_manager.cc:
##########
@@ -94,7 +94,6 @@ void ManifestFilterManager::DeleteFile(std::string_view path)
{
Status ManifestFilterManager::DeleteFile(std::shared_ptr<DataFile> file) {
ICEBERG_PRECHECK(file != nullptr, "Cannot delete file: null");
delete_paths_.insert(file->file_path);
Review Comment:
Keep object deletes distinct from path deletes. Java DeleteFileSet keys
delete files by location + content offset + content size; path-only matching
can remove every DV blob in the same Puffin file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
