rdblue commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3307226510
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -268,67 +286,67 @@ public String toString() {
}
static class Builder {
- private EntryStatus status = null;
- private Long snapshotId = null;
- private Long dataSequenceNumber = null;
- private Long fileSequenceNumber = null;
- private Long dvSnapshotId = null;
- private Long firstRowId = null;
- private byte[] deletedPositions = null;
- private byte[] replacedPositions = null;
-
- Builder status(EntryStatus entryStatus) {
- this.status = entryStatus;
- return this;
- }
-
- Builder snapshotId(Long id) {
- this.snapshotId = id;
- return this;
- }
-
- Builder dataSequenceNumber(Long sequenceNumber) {
- this.dataSequenceNumber = sequenceNumber;
- return this;
+ private final EntryStatus status;
+ private final Long snapshotId;
+ private final Long dataSequenceNumber;
+ private final Long fileSequenceNumber;
+ private final Long firstRowId;
+ private Long dvSnapshotId;
+ private byte[] deletedPositions;
+ private byte[] replacedPositions;
+
+ private Builder(EntryStatus status, long snapshotId) {
+ this.status = status;
+ this.snapshotId = snapshotId;
+ this.dataSequenceNumber = null;
+ this.fileSequenceNumber = null;
+ this.firstRowId = null;
}
- Builder fileSequenceNumber(Long sequenceNumber) {
- this.fileSequenceNumber = sequenceNumber;
- return this;
+ private Builder(EntryStatus status, Tracking source, Long snapshotId) {
+ Preconditions.checkArgument(
+ source.dataSequenceNumber() != null,
+ "Source tracking has no data sequence number; cannot mark as %s",
+ status);
+ Preconditions.checkArgument(
+ source.fileSequenceNumber() != null,
+ "Source tracking has no file sequence number; cannot mark as %s",
+ status);
+ this.status = status;
Review Comment:
It depends on whether we want to build a new tracking for every written file
or not. There's a good argument that we do want to so that we can remove things
that don't need to be carried forward like the `deleted` and `replaced`
bitmaps. But `EXISTING` entries probably don't need to be updated (just
`MODIFIED` entries). It may still be cleaner to build a new one every time
though.
This seems fine for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
