kevinjqliu commented on PR #16566: URL: https://github.com/apache/iceberg/pull/16566#issuecomment-4546407012
thanks for the PR @ajantha-bhat i've done some work with gradle cache recently (https://github.com/apache/iceberg/pull/16356) and made it so that there's only 1 canonical writer. Before this change, I saw that we were constantly getting thrashed by multiple cache writers and cache utilization was really low. Theres also a security component to this, we should only write to cache on push to `main` branch. We should not allow PRs to write to the shared cache since that's a cache poisoning vulnerability. I'm curious how this change effects when to save to cache and how its reused -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
