Baunsgaard commented on code in PR #645:
URL: https://github.com/apache/iceberg-cpp/pull/645#discussion_r3304750732
##########
src/iceberg/deletes/roaring_position_bitmap.h:
##########
@@ -110,6 +112,12 @@ class ICEBERG_DATA_EXPORT RoaringPositionBitmap {
std::unique_ptr<Impl> impl_;
explicit RoaringPositionBitmap(std::unique_ptr<Impl> impl);
+
+ // Bulk-add positions sharing high-32-bit `key`. Internal hook for
+ // `PositionDeleteIndex::BulkAddForKey`; per-key grouping is the caller's
+ // job, keeping this a thin wrapper around CRoaring's `addMany`.
+ void AddManyForKey(int32_t key, const uint32_t* positions, size_t n);
Review Comment:
Okay, i changed it to use std:span
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
