alessandro-nori commented on code in PR #1062:
URL: https://github.com/apache/iceberg-go/pull/1062#discussion_r3303523277
##########
io/gocloud/azure.go:
##########
@@ -159,6 +159,28 @@ func createAzureBucket(ctx context.Context, parsed
*url.URL, props map[string]st
if err != nil {
return nil, fmt.Errorf("failed
container.NewClientFromConnectionString: %w", err)
}
+ } else if props[io.ADLSManagedIdentityEnabled] == "true" {
Review Comment:
The motivation is explained in the PR description `DefaultAzureCredential
sets a short timeout on its first managed identity attempt` and as suggested by
the Azure troubleshooting
[documentation](https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/TROUBLESHOOTING.md#troubleshoot-defaultazurecredential-authentication-issues)
we should use `ManagedIdentityCredential` directly in production
> Use
[ManagedIdentityCredential](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity#ManagedIdentityCredential)
directly, at least in production. It doesn't set a timeout on its
authentication attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
